✨ Install the correct Chromium binary for arm Macs #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
commented
Aug 10, 2021
|
|
||
| for (let rev = state.range[1]; rev >= state.range[0]; rev--) { | ||
| for (; rev >= state.range[0]; rev--) { |
There was a problem hiding this comment.
I got an error with this variable using the latest LTS node with this script. Apparently, let hoisting has changed under the hood. The change makes sense though, as we're referencing rev outside of the loop down below.
wwilsman
force-pushed
the
ww/install-chromium-mac-arm
branch
from
f8e644f
to
8648628
Compare
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.4 to 2.26.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.25.4...v2.26.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
For a while, Chromium for Mac was only built on x64 architecture. With the advent of new M1 arm Macs, it wasn't clear if the Percy CLI even worked on these new macs since we rely on Chromium for asset discovery. I looked back into the Google storage APIs and found that there were recent additions that added Mac arm support. This PR adds the appropriate changes so our install script will download the correct version of Chromium when run on arm based Macs.