✨ Add --debug discovery flag #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular piece of code will not throw an error since it is not awaited on until later, still within the try-catch block
wwilsman
commented
Aug 12, 2021
Comment on lines
+17
to
+18
| if (flags.debug) level = 'debug'; | ||
| else if (flags.verbose) level = 'debug'; |
There was a problem hiding this comment.
Kept these as separate checks in case we ever decide that one of these should produce even more logs
wwilsman
commented
Aug 12, 2021
| @@ -267,7 +269,7 @@ describe('logger', () => { | |||
| expect(helpers.stderr).toEqual([ | |||
| jasmine.stringMatching('Warn log \\(\\dms\\)'), | |||
| jasmine.stringMatching('Error log \\(\\dms\\)'), | |||
| jasmine.stringMatching('Debug log \\((9[0-9]|1[01][0-9])ms\\)'), | |||
| jasmine.stringMatching('Debug log \\(\\d{2,3}ms\\)'), | |||
Robdel12
reviewed
Aug 12, 2021
Robdel12
approved these changes
Aug 12, 2021
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.5.3 to 9.5.4. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v9.5.3...v9.5.4) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Asset discovery issues are typically debugged with the
--verboseflag, or by setting the environment variablePERCY_LOGLEVEL=debug. While this option prints detailed logs throughout the toolchain, including asset discovery, it only does just that — prints detailed logs. However, when debugging asset discovery issues, the constant uploading of any snapshots results in a hit to screenshot usage. It would be beneficial while debugging asset discovery issues to simply not send any snapshots at all, or not even create a build to begin with.This PR introduces a
--debugflag, which not only enables debug logs just like the--verboseflag, but additionally disables snapshot uploads via a new coreskipUploadsoption. This option mirrors the existing (but unused)deferUploadsoption. The two options do the same thing, with the addition of theskipUploadsoption skipping the deferred uploads altogether. The--debugflag could also be an entrypoint for future asset discovery debugging features.The
start()method was adjusted slightly to remove the Percy token check. This token doesn't need to be set when not uploading snapshots or creating builds. The token is also checked before any API call by client, such as the first task of thestart()method, creating a build; this check is also already deferred when uploads are deferred. The creation of the deferred task was also moved outside of the try-catch block since there is nothing to catch until the task is run and awaited on.