✨ Capture different pixel densities in asset discovery #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of real native devices in our rendering infrastructure, we now need to capture 2x++ pixel images for pages to render properly (since the real devices have high pixel density screens). With the new `deviceScaleFactor` config option, we now will resize the browser to each specified width at 1x and also whatever the passed value is for `deviceScaleFactor`. We also run both `beforeResize` and `afterResize` events with the additional scale resizes.
wwilsman
suggested changes
Jun 23, 2022
Robdel12
force-pushed
the
rd/device-scale-factor
branch
2 times, most recently
from
b6c915d
to
bb4e064
Compare
Robdel12
force-pushed
the
rd/device-scale-factor
branch
from
bb4e064
to
55e9190
Compare
Also renamed the new deviceScaleFactor option to devicePixelRatio to better reflect web standards rather than the API option name.
|
I can better articulate my suggestions with code, so after talking about it outside of this thread, I added a commit to change how the pixel ratio is handled. We also decided to rename the option to better reflect web standards rather than the underlying API option name. |
wwilsman
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
With the addition of real native devices in our rendering infrastructure, we now need to capture 2x++ pixel images for pages to render properly (since the real devices have high pixel density screens).
With the new
devicePixelRatioconfig option, we now will resize the browser to each specified width at 1x and also whatever the passed value is fordevicePixelRatio. We also run bothbeforeResizeandafterResizeevents with the additional scale resizes. These assets are discovered in their own tab, separate from 1x devicePixelRatio assets to ensure that the right scaled assets are loaded (rather than trying to resize and reset the devicePixelRatio)