Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Capture different pixel densities in asset discovery #970

Merged
merged 4 commits into from
Jun 27, 2022

Commits on Jun 22, 2022

  1. ✨ Capture different pixel densities in asset discovery

    With the addition of real native devices in our rendering infrastructure, we now
    need to capture 2x++ pixel images for pages to render properly (since the real
    devices have high pixel density screens).
    
    With the new `deviceScaleFactor` config option, we now will resize the browser
    to each specified width at 1x and also whatever the passed value is for
    `deviceScaleFactor`. We also run both `beforeResize` and `afterResize` events
    with the additional scale resizes.
    Robdel12 committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    cfd1f9a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Configuration menu
    Copy the full SHA
    55e9190 View commit details
    Browse the repository at this point in the history
  2. ♻ Trigger resource requests for each pixel ratio

    Also renamed the new deviceScaleFactor option to devicePixelRatio to better reflect web standards
    rather than the API option name.
    wwilsman committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    04d6b9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4dc27d1 View commit details
    Browse the repository at this point in the history