Replies: 3 comments 28 replies
-
|
FYI, here are my "run_settings": {
"cypress_config_file": "./cypress.json",
"project_name": "powderhouse.org",
"build_name": "0.01",
"exclude": [],
"parallels": "1",
"npm_dependencies": {
"@percy/cli": "^1.0.0-beta.76",
"@percy/cypress": "^3.1.1",
"browserslist": "^4.19.3",
"cypress": "^9.5.0"
},
"package_config_options": {},
"headless": true
},
"connection_settings": {
"local": false,
"local_identifier": null,
"local_mode": null,
"local_config_file": null
} |
Beta Was this translation helpful? Give feedback.
-
|
Hey @aresnick! This probably would be better off going to the browserstack-cypress-cli project. It looks like the tests are bundled and uploaded to a browserstack terminal. Percy's SDKs work by capturing & serializing the DOM from the test browser. Then that DOM is FWIW, it's not valuable to run Percy like this since we capture the DOM state and then rerender it across all the browsers. So if you're only running the tests for Percy, you could drop the browserstack-cypress-cli package. BUT that's only if this is just for Percy. I understand if you're wanting to run both the functional tests in different browsers and get Percy snapshots. But it might not be possible to achieve that. |
Beta Was this translation helpful? Give feedback.
-
|
@Robdel12 Yeah, we were hoping to unify the functional tests and the visual regression tests. I made some progress with the help of Princeton below. Should I go ahead and move this issue to the |
Beta Was this translation helpful? Give feedback.
-
|
If The rest of it Princeton should be able to help you work through. 💯 |
Beta Was this translation helpful? Give feedback.
-
|
OK; perfect— Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
Based on an email thread with Princeton, I tried changing But luckily, the screenshot does in fact load— However, the fonts are not loading, despite loading locally. I've also verified that the fonts load on a device which didn't have the fonts installed locally, meaning they are served correctly. Any thoughts as to what the issue might be with:
Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
I suppose we were hoping to be able to do both, since it seems much faster on my local machine @Robdel12 I think part of the issue might be that headless Electron doesn't seem to take that arg, but I can't seem to find anything that does something similar in the Electron options? |
Beta Was this translation helpful? Give feedback.
-
|
Gotcha, you'll want to try running in an env that doesn't have the fonts already installed (some kind of VM or by uninstalling the fonts). That way the browser does make the request for the fonts and saves them in asset discovery. It doesn't look like there's many options out there for telling a browser to ignore system installed fonts: https://stackoverflow.com/questions/44788343/how-to-force-chrome-to-ignore-locally-installed-google-fonts There appears to be an experimental API in CDP to disable local fonts, which might help this. We'll have to explore that but it's also marked as experimental so I'm not sure what their plans are for this in the future https://chromedevtools.github.io/devtools-protocol/tot/CSS/#method-setLocalFontsEnabled
FWIW, Percy's SDKs don't use Electron, we're controlling a Chromium browser directly via CDP. The args you pass in from |
Beta Was this translation helpful? Give feedback.
-
|
Got it; that makes sense— Sorry, I was getting distracted by the mention of Electron from running the tests through cypress. Happy to take a stab at trying the CDP approach. I haven't used CDP before, so if there's an easy example repo around of integrating it with a cypress/Percy test, that'd be appreciated! Thanks again. |
Beta Was this translation helpful? Give feedback.
-
|
Ah sorry, there's nothing you'll be able to do with CDP. I was just describing how the SDKs work under the hood. The action you can take at the moment is to disable the font in macOS fontbook so the browser then will request the font in asset discovery. In a future sprint we'll look at the |
Beta Was this translation helpful? Give feedback.
-
|
Ah, got it— Thank you so much for all your help! |
Beta Was this translation helpful? Give feedback.
-
The problem
I've successfully run tests with Cypress and Percy locally, and am now trying to use
browserstack-cypress-clito take screenshots via Percy.When I run a basic test using
cy.percySnapshot(), no screenshot is delivered.NB: If this should be logged as an issue with
browserstack-cypress-cli, let me know.Environment
node v14.18.1 (npm v8.3.0)@percy/cliversion:@percy/cli 1.0.0-beta.76@percy/cypress ^3.1.1Windows 10versions["latest", "latest-1"]yarn run percy exec --verbose -- browserstack-cypress run --syncDetails
When I run my test command, the test completes (successfully appearing in Automate as well), but in Percy no snapshot seems to be uploaded, and although I pass the
--verboseoption, no logs seem to appear anywhere.Debug logs
These are the logs from my terminal when I run the test; I can't seem to locate any remote logs on Percy
On Automate, the logs don't indicate any issue:
Code to reproduce issue
Happy to create a repo if needed, but right now it's tied into our site setup and similar. Hopefully this is enough to work with?
Beta Was this translation helpful? Give feedback.
All reactions