Bump from 2.3.3 to 3.10 - RangeError: Maximum call stack size exceeded

[iondrimba]

After upgrading a personal project to version 3.1.0 some of my cypress spec started failing with the error below
I'm using cypress 7.1.0

RangeError: Maximum call stack size exceeded
    at _deconstructPacket (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:21:28)
    at Object.deconstructPacket (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:16:17)
    at Encoder.encodeAsBinary (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:81:41)
    at Encoder.encode (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:43:29)
    at Client._packet (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io/dist/client.js:167:44)
    at Socket.packet (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io/dist/socket.js:161:21)
    at /home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/socket/node_modules/socket.io/dist/socket.js:270:18
    at /home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/lib/socket-base.js:325:28
    at tryCatcher (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/promise.js:725:18)
    at _drainQueueStep (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/home/circleci/.cache/Cypress/7.1.0/Cypress/resources/app/packages/server/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (internal/timers.js:461:21)

Rolling back to version 2.3.4 everything works ok

[iondrimba]

I did the migration steps from v2 to v3 according to the documentation

[Robdel12]

Yikes, looks like this is impacting headless runs too. This is related to a Cypress bug: cypress-io/cypress#15101

The reason 2.x doesn't have this issue is because we use a node task to execute the health check (which has always been a workaround). In 3.x we were able to remove that hack, but now we're being bit by this networking bug in Cypress. You can replace cy.percySnapshot() with cy.request('http://unreachable-url:1337/') and it too will hang and crash.

Related to #315 & #320. Going to leave this open until the bug is fixed in Cypress upstream.

[iondrimba]

thanks for clarifying @Robdel12

[iondrimba]

@Robdel12 I created a reproducible repo https://github.com/iondrimba/cypress_maximum_call_stack

[iondrimba]

@Robdel12 Updated the reproducible repo with a successful case without percy

[iondrimba]

Almost ready cypress-io/cypress#16311 🎉

[Robdel12]

Very exciting!! 👀

[pyymenta]

Ready! 🎉 https://github.com/cypress-io/cypress/releases/tag/v7.3.0

@iondrimba @Robdel12

[Robdel12]

Going to guess everything is smooth on 7.3.0+ now? If so I'll close this out 😃

[iondrimba]

[iondrimba]

Everything works now on the latest cypress release 7.3.0