[Cypress regression]`TypeError: data.hasOwnProperty is not a function` #434

pun-ky · 2021-11-24T10:49:43Z

The problem

After adding line to cypress/support/index.js:

import '@percy/cypress';

then running Cypress fails with:

 Product Page
TypeError: data.hasOwnProperty is not a function
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:39:22)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:32:26)
    at Object.deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:16:17)
    at Encoder.encodeAsBinary (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:80:41)
    at Encoder.encode (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:42:29)
    at Client._packet (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/client.js:169:44)
    at Socket.packet (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/socket.js:160:21)
    at /Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/socket.js:274:18
    at /Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/lib/socket-base.js:318:28
    at tryCatcher (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:725:18)
    at _drainQueueStep (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (node:internal/timers:464:21)

TypeError: data.hasOwnProperty is not a function
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:39:22)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:40:32)
    at _deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:32:26)
    at Object.deconstructPacket (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/binary.js:16:17)
    at Encoder.encodeAsBinary (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:80:41)
    at Encoder.encode (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io-parser/dist/index.js:42:29)
    at Client._packet (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/client.js:169:44)
    at Socket.packet (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/socket.js:160:21)
    at /Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/socket/node_modules/socket.io/dist/socket.js:274:18
    at /Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/lib/socket-base.js:318:28
    at tryCatcher (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/promise.js:725:18)
    at _drainQueueStep (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/krystian.panek/Library/Caches/Cypress/9.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (node:internal/timers:464:21)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

When I am downgrading cypress to:

    "cypress": "^8.7.0",

There is no error. Everything works properly.

Environment

  "devDependencies": {
    "cypress": "^9.1.0",
    "mocha": "^9.1.3",
    "mochawesome": "^7.0.1",
    "cypress-mochawesome-reporter": "^2.3.0",
    "cypress-multi-reporters": "^1.5.0",
    "mocha-junit-reporter": "^2.0.2",
    "typescript": "4.5.2",
    "@percy/cli": "^1.0.0-beta.70",
    "@percy/cypress": "^3.1.1"
  }

Node version: 16 LTS
MaxOS BigSur

The text was updated successfully, but these errors were encountered:

cexbrayat · 2021-11-24T14:04:44Z

Just ran into the same issue. Note that it works with Cypress v9.0, but not with v9.1

Robdel12 · 2021-11-24T14:19:53Z

👋🏼 I'm not at my computer to debug this yet but it feels like a red herring that there's nothing Percy related in that stack trace. Why is there bluebird in the stack trace (really old promise dep)? 🤨

I see "typescript": "4.5.2", in your provided packag.json. Given the example app works fine with Cypress v9, I suspect this is actually a typescript + Cypress problem (and maybe + Percy too, there's also this annoying TS bug: #430)

cexbrayat · 2021-11-24T14:37:30Z

@Robdel12 This appears to be related to percy: if I remove all the related code to percy, it works fine again in my case (on several projects). We do use TS as well, both TS 4.4 and TS 4.5.

Robdel12 · 2021-11-24T17:53:14Z

This sure does smell a lot like cypress-io/cypress#15101 & #325

cexbrayat · 2021-11-24T17:55:35Z

It does. I also had that issue in the past, but this was fixed and had not happened again since.

cexbrayat · 2021-11-25T07:00:54Z

FYI someone opened a similar issue on Cypress cypress-io/cypress#19091

atmullan · 2021-11-26T09:50:16Z

Also getting this issue after upgrade to 9.1.0, I have percy enabled.

atmullan · 2021-11-26T10:14:36Z

Downgrading to Cypress 9.0.0 Resolves the issue for me. Note: Not using Typescript

geoffharcourt · 2021-11-26T15:42:52Z

We're seeing error this happen, but only in specs that have involve @percy/cypress, and only as of Cypress 9.1.

Robdel12 · 2021-11-29T17:07:16Z

My guess is Cypress had a regression in their networking stack. Percy's SDK POST's the DOM snapshot to local Percy server and this was an issue in Cypress in the past (with almost the exact same error message). People are reporting seeing the same issue without Percy and the stack trace doesn't have any Percy code in it.

Looks like we'll have to wait for Cypress to patch

Robdel12 · 2021-12-02T21:09:08Z

I added a comment to the Cypress issue, but this doesn't appear to be a Percy issue. Staying on v9.0.x will stay away from the issue (I believe) while this is looked at by the Cypress folks. Here's the comment I left on their issue:

I spent some time digging in to try and isolate & reproduce.

describe("Breaking reproduction", function () {
  it("doesn't throw an error when making requests", function () {
    cy.then(() =>
      Cypress.backend("http:request", {
        url: "http:localhost:8001/nothing/here",
        method: "POST",
      })
    );
  });
});

This will break with the same stack trace in the OP (https://github.com/percy/example-percy-cypress/runs/4400801282?check_suite_focus=true)

Robdel12 · 2021-12-06T17:27:06Z

Upgrading to v9.1.1 of cypress should solve this cypress-io/cypress#19091

Warn users when using percy-cypress along with known incompatible cypress v9.1.0 See: percy#437 (comment) percy#434

Robdel12 changed the title ~~Incompatible with Cypress 9.x~~ TypeScript bundling issue (TypeError: data.hasOwnProperty is not a function) Nov 24, 2021

cexbrayat mentioned this issue Nov 25, 2021

Possible regression in Cypress 9.1: TypeError: data.hasOwnProperty is not a function cypress-io/cypress#19091

Closed

Robdel12 changed the title ~~TypeScript bundling issue (TypeError: data.hasOwnProperty is not a function)~~ [Cypress regression]TypeError: data.hasOwnProperty is not a function Nov 26, 2021

CyrilKrylatov mentioned this issue Dec 2, 2021

Make running Percy integration optional #3

Closed

Robdel12 closed this as completed Dec 7, 2021

esetnik added a commit to esetnik/percy-cypress that referenced this issue Dec 8, 2021

Mark incompatible with cypress v9.1.0

c0e4453

Warn users when using percy-cypress along with known incompatible cypress v9.1.0 See: percy#437 (comment) percy#434

esetnik mentioned this issue Dec 8, 2021

Mark incompatible with cypress v9.1.0 #444

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cypress regression]`TypeError: data.hasOwnProperty is not a function` #434

[Cypress regression]`TypeError: data.hasOwnProperty is not a function` #434

pun-ky commented Nov 24, 2021

cexbrayat commented Nov 24, 2021

Robdel12 commented Nov 24, 2021 •

edited

Loading

cexbrayat commented Nov 24, 2021

Robdel12 commented Nov 24, 2021

cexbrayat commented Nov 24, 2021

cexbrayat commented Nov 25, 2021

atmullan commented Nov 26, 2021

atmullan commented Nov 26, 2021

geoffharcourt commented Nov 26, 2021

Robdel12 commented Nov 29, 2021

Robdel12 commented Dec 2, 2021 •

edited

Loading

Robdel12 commented Dec 6, 2021

[Cypress regression]TypeError: data.hasOwnProperty is not a function #434

[Cypress regression]TypeError: data.hasOwnProperty is not a function #434

Comments

pun-ky commented Nov 24, 2021

The problem

Environment

cexbrayat commented Nov 24, 2021

Robdel12 commented Nov 24, 2021 • edited Loading

cexbrayat commented Nov 24, 2021

Robdel12 commented Nov 24, 2021

cexbrayat commented Nov 24, 2021

cexbrayat commented Nov 25, 2021

atmullan commented Nov 26, 2021

atmullan commented Nov 26, 2021

geoffharcourt commented Nov 26, 2021

Robdel12 commented Nov 29, 2021

Robdel12 commented Dec 2, 2021 • edited Loading

Robdel12 commented Dec 6, 2021

[Cypress regression]`TypeError: data.hasOwnProperty is not a function` #434

[Cypress regression]`TypeError: data.hasOwnProperty is not a function` #434

Robdel12 commented Nov 24, 2021 •

edited

Loading

Robdel12 commented Dec 2, 2021 •

edited

Loading