chore: remove ember-cli-htmlbars from dependencies
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this addon provides no templates, it doesn't have to ship the `ember-cli-htmlbars` as a dependency. This prevents it from being added to the dependencies of an installer of `ember-percy` if they are using an older version.
Robdel12
approved these changes
Dec 18, 2019
|
No problem! |
|
Published with v2.0.0-beta.2 😃 |
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this addon provides no templates, it doesn't have to ship the
ember-cli-htmlbarsas a dependency. This prevents it from being added to the dependencies of an installer ofember-percyif they are using an older version.This is of particular note because
ember-cli-htmlbarsis new major version, meaning that an app still using3.X.Xmight need to install version 4.0 just forember-percy, where it isn't actually used.