fix: Workaround for domTransformation error caused by empty document #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, looks like GH actions does not allow me to run a build with a real |
|
Ah, right, thanks for this PR! 🎉 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure why but
domTransformationfunction is called 2 times for a singlepercySnapshotcall. First time it's called with an empty<html><body>document sohoistAppDomfails with message like:This is actually visible in the test log of this very project, for example this build (expand "Percy Test"): https://github.com/percy/ember-percy/runs/1055338113
Maybe there's a better fix for this but I'd really like to get rid of those annoying error logs 😅