Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK tests and CircleCI integration #26

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Add SDK tests and CircleCI integration #26

merged 2 commits into from
Dec 7, 2018

Conversation

anaulin
Copy link
Contributor

@anaulin anaulin commented Dec 7, 2018

Still pending:

Example successful CircleCI build: https://circleci.com/gh/percy/percy-puppeteer/16
And associated Percy build: https://percy.io/sdks/-percy-puppeteer/builds/1229375

const should = require('chai').should()
const puppeteer = require('puppeteer')
const httpServer = require('http-server')
const { percySnapshot } = require('../dist')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way to hook in here

Copy link
Contributor

@djones djones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

@anaulin anaulin merged commit c3e1530 into master Dec 7, 2018
@anaulin anaulin deleted the sdk-tests branch December 7, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants