✨ add storybook v7 support #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add fetching env support for storybook v7+ * chore: lint using --fix
This was
linked to
issues
Oct 19, 2023
Closed
itsjwala
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Looks good so far, nice!
- we'll need backward compatibility with v6 and have to figure out how we can add tests for same.
- we'll create E2E build on Percy and verify visual regression if any with v6 vs v7 and callout.
- how many customers use node 14? we might need to have CI tests on node 14 as well.
itsjwala
reviewed
Oct 19, 2023
|
I have noticed that the tests are flaky. Both of them are for the same commit ids |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nilshah98
force-pushed
the
add-storybookv7-support
branch
from
9c585a4 to
c23158d
Compare
nilshah98
force-pushed
the
add-storybookv7-support
branch
from
e9d2002 to
8f6230d
Compare
…y run yarn in their workflows
itsjwala
reviewed
Oct 26, 2023
This was
unlinked from
issues
Oct 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description -
evalStorybookEnvironmentInfoto grep storybook v7 versionevalStorybookStorySnapshotsto support fetching all stories even withstoryStorev7: truestart-storybooktostorybook dev)16and update github actions to use node16cacheAllCSFFileswithstoryStorev7: falseand also older storybook version