Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added darwin_arm64 and updated linux_arm_* #2

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Conversation

conotto
Copy link
Contributor

@conotto conotto commented Oct 26, 2022

Added darwin_arm64 and updated linux_arm_* from https://ftdichip.com/drivers/d2xx-drivers/

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #2 (7b43a91) into main (86eb5ae) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main      #2   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        416     416           
=====================================
  Misses       416     416           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maruel
Copy link
Member

maruel commented Oct 26, 2022

Thanks!

Can you delete the old ones and update the path, e.g. see https://github.com/periph/d2xx/blob/main/d2xx_darwin_amd64.go

@conotto
Copy link
Contributor Author

conotto commented Oct 26, 2022

Thanks!

Can you delete the old ones and update the path, e.g. see https://github.com/periph/d2xx/blob/main/d2xx_darwin_amd64.go

Ok, its complete

@maruel
Copy link
Member

maruel commented Oct 26, 2022

A wild .DS_Store file got added! I recommend a global exclusion: create a file called ~/.config/git/ignore. Here's an example content: https://github.com/maruel/bin_pub/blob/main/configs/.config/git/ignore

See https://git-scm.com/docs/gitignore more info.

@conotto
Copy link
Contributor Author

conotto commented Oct 26, 2022

A wild .DS_Store file got added! I recommend a global exclusion: create a file called ~/.config/git/ignore. Here's an example content: https://github.com/maruel/bin_pub/blob/main/configs/.config/git/ignore

See https://git-scm.com/docs/gitignore more info.

🤦 Its fixed now

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A note about GOARCH that only supports "arm" and "arm64" but not other levels.

d2xx_linux_arm7hf.go Outdated Show resolved Hide resolved
d2xx_darwin_arm64.go Outdated Show resolved Hide resolved
@maruel
Copy link
Member

maruel commented Oct 26, 2022

Thanks! If you don't mind I'll do a quick check on my M1 later today. I'll also probably update the go minimal supported version to go1.17 due to a recent breakage of golang.org/x/sys golang/go#55078

@conotto
Copy link
Contributor Author

conotto commented Oct 26, 2022

Thanks! If you don't mind I'll do a quick check on my M1 later today. I'll also probably update the go minimal supported version to go1.17 due to a recent breakage of golang.org/x/sys golang/go#55078

Sounds good, please let me know if anything else is required.

@maruel maruel merged commit 88633f6 into periph:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants