Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

videosink: Add options for JPEG and PNG encoders #30

Merged
merged 1 commit into from
Dec 8, 2021
Merged

videosink: Add options for JPEG and PNG encoders #30

merged 1 commit into from
Dec 8, 2021

Conversation

hansmi
Copy link
Contributor

@hansmi hansmi commented Dec 8, 2021

Expose the quality settings for the JPEG encoder and the compression
level of the PNG encoder via the Options structure.

Relates to #26.

Expose the quality settings for the JPEG encoder and the compression
level of the PNG encoder via the Options structure.

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #30 (e989a2f) into main (42ee855) will increase coverage by 0.1%.
The diff coverage is 92.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #30     +/-   ##
=======================================
+ Coverage   61.2%   61.3%   +0.1%     
=======================================
  Files         53      53             
  Lines       6672    6690     +18     
=======================================
+ Hits        4085    4103     +18     
  Misses      2446    2446             
  Partials     141     141             
Impacted Files Coverage Δ
videosink/handler.go 82.5% <0.0%> (ø)
videosink/display.go 90.0% <100.0%> (+2.5%) ⬆️
videosink/encoder.go 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ee855...e989a2f. Read the comment docs.

@maruel maruel merged commit 37f977f into periph:main Dec 8, 2021
@maruel
Copy link
Member

maruel commented Dec 8, 2021

Thanks!

@hansmi hansmi deleted the vsopt1 branch December 11, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants