Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveshare213v2: Make busy a PinIn, use WaitForEdge #40

Merged
merged 1 commit into from
Dec 22, 2021
Merged

waveshare213v2: Make busy a PinIn, use WaitForEdge #40

merged 1 commit into from
Dec 22, 2021

Conversation

hansmi
Copy link
Contributor

@hansmi hansmi commented Dec 22, 2021

The busy pin from the e-paper display is only used to read, not to
write, and thus there's no need for the PinIO interface. PinIn is
enough.

In addition the WaitForEdge function can be used to shorten the delays
when waiting for the display to become idle. Spurious or missed edges
are acceptable: the delay isn't very long.

The busy pin from the e-paper display is only used to read, not to
write, and thus there's no need for the PinIO interface. PinIn is
enough.

In addition the WaitForEdge function can be used to shorten the delays
when waiting for the display to become idle. Spurious or missed edges
are acceptable: the delay isn't very long.
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #40 (45561a7) into main (5179e40) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #40   +/-   ##
=====================================
  Coverage   62.5%   62.5%           
=====================================
  Files         55      55           
  Lines       6720    6723    +3     
=====================================
+ Hits        4202    4204    +2     
- Misses      2377    2378    +1     
  Partials     141     141           
Impacted Files Coverage Δ
waveshare2in13v2/errorhandler.go 0.0% <0.0%> (ø)
waveshare2in13v2/waveshare213v2.go 0.0% <0.0%> (ø)
as7262/as7262.go 99.3% <0.0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5179e40...45561a7. Read the comment docs.

@maruel maruel merged commit 347b4e2 into periph:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants