waveshare2in13v2: Support rotation of image #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forthcoming introduction of image orientation will make the computation slightly more complicated. The bounds are fixed during the lifetime of a "Dev" instance, so it's better to retain them.
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
+ Coverage 64.1% 64.4% +0.4%
=======================================
Files 56 56
Lines 6740 6821 +81
=======================================
+ Hits 4317 4393 +76
- Misses 2279 2284 +5
Partials 144 144
Continue to review full report at Codecov.
|
maruel
reviewed
Jan 22, 2022
The members of the "drawSpec" structure are only for internal use, so rename them to start with a lower-case letter.
A new option named "Origin" controls which of the four corners of the display should be used as the (0,0) position for the image. The in-memory buffer is kept in logical orientation. The actual rotation happens only when sending updates. By aligning the buffer accordingly the code is already prepared for a more efficient sending of image data for the "TopRight" and "BottomLeft" origins. See the TODO comment on "drawSpec.BufferDstOffset" for details. Signed-off-by: Michael Hanselmann <public@hansmi.ch>
maruel
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option named
Origincontrols which of the four corners of the display should be used as the (0,0) position for the image. The included unittests may seem excessive, but they are the result of many off-by-one errors and other mistakes I made while developing this series.