-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adxl345: Driver, initial commit for review. #66
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=====================================
Coverage 62.5% 62.5%
=====================================
Files 64 64
Lines 7337 7337
=====================================
Hits 4585 4585
Misses 2598 2598
Partials 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
- Moved the Sensitivity constants to a dedicated section. - SpiFrequency is set to 2Mz ( ADXL345 supports up to 5Mz ) - Removed the TurnOnOnStart options, we start measuring on instantiation. - Minor typo and example.go fix.
Please fix the CI error. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things then it's good to go.
Please prefix the issue title with the primary package affected. For example,
if this PR fixes periph.io/x/devices/v3/cap1xxx, prefix the PR title with "cap1xxx:".
Mention the issue number it fixes or add the details of the changes if it
doesn't have a specific issue. Examples:
new functionality (if relevant).