Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adxl345: Driver, initial commit for review. #66

Merged
merged 10 commits into from
Dec 28, 2023

Conversation

benoit-pereira-da-silva
Copy link
Contributor

  1. Please prefix the issue title with the primary package affected. For example,
    if this PR fixes periph.io/x/devices/v3/cap1xxx, prefix the PR title with "cap1xxx:".

  2. Mention the issue number it fixes or add the details of the changes if it
    doesn't have a specific issue. Examples:

  • Added basic support for the adxl345 accelerometer.
  1. Once integrated, send a PR to https://github.com/periph/cmd to leverage the
    new functionality (if relevant).

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c14e02d) 62.5% compared to head (b62bbe2) 62.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #66   +/-   ##
=====================================
  Coverage   62.5%   62.5%           
=====================================
  Files         64      64           
  Lines       7337    7337           
=====================================
  Hits        4585    4585           
  Misses      2598    2598           
  Partials     154     154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

adxl345/adxl345.go Show resolved Hide resolved
adxl345/adxl345.go Outdated Show resolved Hide resolved
adxl345/adxl345.go Outdated Show resolved Hide resolved
adxl345/adxl345.go Show resolved Hide resolved
adxl345/example/example.go Outdated Show resolved Hide resolved
- Moved the Sensitivity constants to a dedicated section.
- SpiFrequency is set to 2Mz ( ADXL345 supports up to 5Mz )
- Removed the TurnOnOnStart options, we start measuring on instantiation.
- Minor typo and example.go fix.
@maruel
Copy link
Member

maruel commented Dec 28, 2023

Please fix the CI error.

@benoit-pereira-da-silva
Copy link
Contributor Author

Please fix the CI error
I m sorry but i can't figure out what is that error

fatal: cannot mkdir /home/cuong/go/src/github.com/benoit-pereira-da-silva/devices-0: No space left on device

@maruel
Copy link
Member

maruel commented Dec 28, 2023

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things then it's good to go.

adxl345/adxl345.go Outdated Show resolved Hide resolved
adxl345/adxl345.go Outdated Show resolved Hide resolved
@maruel maruel merged commit 931687b into periph:main Dec 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants