-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AHT20 sensor #68
Add AHT20 sensor #68
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=====================================
Coverage 61.6% 61.6%
=====================================
Files 65 65
Lines 7442 7442
=====================================
Hits 4583 4583
Misses 2705 2705
Partials 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new driver! Please resolve the github actions failure.
Thanks for the fast reaction on this PR! I resolved your issue and the pipeline issues. Somehow, Should I add some tests using the bus mock as in bmxx80? |
I try to keep compatibility with older version of Go since it's what is installed via apt-get install and users could be confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better if you can add tests but I won't require it.
Implemented the AHT20 environmental sensor using the
SenseEnv
interface. Implementation is based on this Datasheet. Tested on a RaspberryPi with the AHT20 sensor.Features:
Sense()
reads a single measurementSenseContinuous()
reads measurements with the given interval into a channel (or as fast as possible if it is too small)Halt()
stops a continuous measurement