Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: Add support for AM2320 Temperature/Humidity Sensor #82

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

gsexton
Copy link
Contributor

@gsexton gsexton commented Nov 23, 2024

No description provided.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 48.4%. Comparing base (5bc0352) to head (d9959d6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
am2320/am2320.go 88.0% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #82     +/-   ##
=======================================
+ Coverage   47.5%   48.4%   +0.8%     
=======================================
  Files         87      89      +2     
  Lines      10935   11351    +416     
=======================================
+ Hits        5197    5490    +293     
- Misses      5542    5629     +87     
- Partials     196     232     +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The only issue is line 4 to make it an empty line so the documentation is proper. The rest is optional.

am2320/am2320.go Outdated Show resolved Hide resolved
am2320/am2320.go Outdated Show resolved Hide resolved
am2320/am2320.go Outdated Show resolved Hide resolved
am2320/am2320.go Outdated Show resolved Hide resolved
@maruel maruel merged commit 7fd42d5 into periph:main Nov 25, 2024
10 checks passed
@maruel
Copy link
Member

maruel commented Nov 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants