Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allwinner: Support for H2+ and H3 (OrangePiZero) #23

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

f0086
Copy link
Contributor

@f0086 f0086 commented Dec 13, 2022

Add support for the Allwinner H2+ and H3 CPUs, which are almost identical. The H2+ has no GBit MAC and no 4h HDMI, but the rest is completely identical. For this library tho, it is not relevant, so we can combine these two CPU types into one single H3 and detect the H2+ as a H3 CPU.

Support for detecting Orange Pi Zero boards are added, which uses the H3 SOC. The Pinouts are from the Orange Pi manual.

Fixes #1

Add support for the Allwinner H2+ and H3 CPUs, which are almost
identical. The H2+ has no GBit MAC and no 4h HDMI, but the rest is
completely identical. For this library tho, it is not relevant, so we
can combine these two CPU types into one single H3 and detect the H2+ as
a H3 CPU.

Support for detecting Orange Pi Zero boards are added, which uses the H3
SOC. The Pinouts are from the Orange Pi manual.

This resolves periph#1
@maruel
Copy link
Member

maruel commented Dec 13, 2022

gohci

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #23 (b7b49dd) into main (de9a57f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   34.3%   34.3%           
=====================================
  Files         51      51           
  Lines       7992    7992           
=====================================
  Hits        2744    2744           
  Misses      5117    5117           
  Partials     131     131           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!
Please fix the CI failures and the issue I noted and you're good to good.

allwinner/h3.go Show resolved Hide resolved
orangepi/doc.go Outdated Show resolved Hide resolved
* Add the 2022 copyright header on all changed files.
* Document all functions, vars and structs.
* Propagate unhandled errors.
* Add me to the list of contributors.
@f0086 f0086 changed the title allwinner: Support for H2+ and H3 (OrangePiSZero) allwinner: Support for H2+ and H3 (OrangePiZero) Dec 14, 2022
AUTHORS Outdated
@@ -12,4 +12,4 @@ Max Ekman <max@looplab.se>
Rifiniti, Inc
Stephan Sperber
Thorsten von Eicken <tve@voneicken.com>

Aaron Fischer <mail@aaron-fischer.net>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put at the top to keep sorted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the codespace thing to edit your PR but the flow failed. Obviously I can't push to your git repo, then it prompted to fork and failed because I already have a personal fork. Oh well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) I've updated the AUTHORS and CONTRIBUTORS file accordingly. I did not get the difference between these two files tho. People who contribute code /are/ contributors and authors and hold copyright. Do I need to sign some paperwork?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I submitted the CLA.

@maruel
Copy link
Member

maruel commented Dec 16, 2022

Thanks!

@maruel maruel merged commit 339d73c into periph:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

allwinner: extend supported CPUS (H2, H3)
3 participants