fs,sysfs: use EPOLL_EXEC to clean up epoll file descriptors on execve(2) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error is not your fault, let me take a look in O(hours) to O(days). |
|
#33 should fix it |
maruel
approved these changes
Apr 27, 2023
|
Can you try rebasing on top of origin/main now? |
EPOLL_EXEC is O_CLOEXEC for epoll_create1, which is a good default for any file descriptor not explicitly designed to survive an exec.
|
Done. |
Really? As far as I can tell, v3.8.1 doesn't contain this change. It does contain the go 1.20 bump, however. |
|
Operator error, see https://github.com/periph/host/releases/tag/v3.8.2 |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPOLL_EXEC is O_CLOEXEC for epoll_create1, which is a good default for any file descriptor not explicitly designed to survive an exec.