-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix mixed console output on Windows #191
base: master
Are you sure you want to change the base?
Conversation
When executing carton exec COMMAND on Windows, the command returns, to the command prompt, while it's running if exec is used. system behaves correctly
Any thoughts on this changeset? It really helps windows users |
Conflicts: lib/Carton/Builder.pm lib/Carton/CLI.pm
Any progress with this merge request? I am also suffering from this issue, trying to run carton exec ... in Teamcity and as it forks/exec, Teamcity thinks the process ended immediately after start. |
Hi @miyagawa Would you reconsider the patch in 1331aac for carton? It really helps carton exec behave the same way under Windows and Linux, and as @tynovsky reports, it seems I'm not alone. I'm maintaining a mini-fork of carton for our use into which I have merged some outstanding PRs that we needed (that's why you see more commits on this PR). Only 1331aac solves the "mixed output" problem. @miyagawa: I know you are dedicating time to Carmel. Do you think I can help you get some carton work done? |
cherry-picked 1331aac I think win32 users would better skip |
I reverted the cherry-picked patch above, and instead added |
When executing carton exec COMMAND on Windows, the command returns to
the command prompt while it's running. Using system instead of exec on Windows makes carton behave correctly