Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix mixed console output on Windows #191

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pplu
Copy link
Contributor

@pplu pplu commented Mar 31, 2015

When executing carton exec COMMAND on Windows, the command returns to
the command prompt while it's running. Using system instead of exec on Windows makes carton behave correctly

Errorific and others added 3 commits October 8, 2013 16:06
When executing carton exec COMMAND on Windows, the command returns, to
the command prompt, while it's running if exec is used. system behaves
correctly
@pplu
Copy link
Contributor Author

pplu commented Jun 6, 2015

Any thoughts on this changeset? It really helps windows users

@tynovsky
Copy link

Any progress with this merge request? I am also suffering from this issue, trying to run carton exec ... in Teamcity and as it forks/exec, Teamcity thinks the process ended immediately after start.

@pplu
Copy link
Contributor Author

pplu commented May 12, 2016

Hi

@miyagawa Would you reconsider the patch in 1331aac for carton? It really helps carton exec behave the same way under Windows and Linux, and as @tynovsky reports, it seems I'm not alone.

I'm maintaining a mini-fork of carton for our use into which I have merged some outstanding PRs that we needed (that's why you see more commits on this PR). Only 1331aac solves the "mixed output" problem.

@miyagawa: I know you are dedicating time to Carmel. Do you think I can help you get some carton work done?

@miyagawa
Copy link
Contributor

cherry-picked 1331aac

I think win32 users would better skip carton exec and do use lib local/lib/perl5 though.

@miyagawa
Copy link
Contributor

I reverted the cherry-picked patch above, and instead added carton run which doesn't invoke exec. That way, carton exec will always be exec regardless of platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants