Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log a non-JSON message to STDERR on linting success when --json is enabled #107

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

oalders
Copy link
Member

@oalders oalders commented Jan 13, 2024

The message on STDERR was breaking nvim-lint and it's also weird.

@oalders oalders force-pushed the quieter-json-output branch from 2fd3153 to cfc0e0a Compare January 13, 2024 11:56
@oalders oalders force-pushed the quieter-json-output branch from cfc0e0a to 70b8860 Compare January 13, 2024 12:11
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3d7ec8) 87.29% compared to head (70b8860) 87.41%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   87.29%   87.41%   +0.11%     
==========================================
  Files           9        9              
  Lines         866      866              
  Branches      196      196              
==========================================
+ Hits          756      757       +1     
+ Misses         83       82       -1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oalders oalders merged commit 5795030 into main Jan 13, 2024
27 checks passed
@oalders oalders deleted the quieter-json-output branch January 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant