fix some queries with columns beginning with limit
would fail
#349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#288 fixes a problem in which SQL involving columns whose names end in
limit
cannot be generated successfully.However, this fix caused SQL containing columns starting with
limit
to fail to generate successfully (e.g.SELECT * FROM table WHERE limit_by > ?
).This is because the syntax interpretation compares it to
limit
when it should be compared tolimit
which includes white space.I have created a fix for this problem and a test code that can confirm this issue.
With 4.050, modified t/35limit.t fails, but when this pull request is applied, it succeeds.