Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidied up pod documentation for sub frequency. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manwar
Copy link

@manwar manwar commented Aug 18, 2020

Hi @rehsack

During the live session with Lance Wicks doing the weekly challenge, we found out the documentation for sub frequency was not very explicit as far as example in the doc.

https://www.youtube.com/watch?v=uM0TTQZaZ2Q

In this PR, I propose a verbose example usage of sub frequency.

Please review the PR when you get time.

I don't expect you to push a new release just for this but I would appreciate if you could please accept and merge the PR.

Many Thanks.

Best Regards,
Mohammad

@rehsack
Copy link
Member

rehsack commented Oct 5, 2020

While I appreciate an improved example, all other given examples a way more compact.
An example with some strings and not only numbers is likely preferred, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants