Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain payloads, minor bug fixes #268

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Chain payloads, minor bug fixes #268

merged 11 commits into from
Mar 29, 2024

Conversation

patinthehat
Copy link
Member

This PR adds the ray().chain() method, as described in #267. It also fixes several minor bugs, removes an unused package dependency and updates the documentation.

Copy link

what-the-diff bot commented Mar 29, 2024

PR Summary

  • Providing a New Method for Payload Chaining
    An addition to our code introduces a method ray().chain(callback). It navigates our data sending process smoothly by joining multiple Ray payloads and forwarding them all in a single instance.

  • Update on Documentation
    Revisions have been made to our README.md file, bringing it up to date with the changes introduced in the new variant of node-ray.

  • Adding Delays to Enhance Payload Handling
    We've updated the Client.ts file to integrate a small delay after each payload is sent. This adjustment ensures a better synchronization in sending and receiving data.

  • Enhancing Payload Chaining
    We've also made changes in Ray.ts, enhancing how we handle the chaining of payloads. This improvement in process ensures data gets sent in a more organized manner.

  • Test Cases for New Method
    To ensure the effectiveness of our new update, we've introduced unit tests specific to the new ray().chain() method. Through these tests, we are more confident about the robustness of our enhanced data sending functionality.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.34%. Comparing base (dda2566) to head (970f975).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   87.27%   87.34%   +0.07%     
==========================================
  Files          67       67              
  Lines        3377     3403      +26     
  Branches      526      529       +3     
==========================================
+ Hits         2947     2972      +25     
- Misses        430      431       +1     
Files Coverage Δ
src/lib/types.ts 56.37% <100.00%> (+1.65%) ⬆️
src/Client.ts 63.91% <0.00%> (-0.48%) ⬇️
src/Ray.ts 86.00% <96.30%> (+0.41%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda2566...970f975. Read the comment docs.

@patinthehat patinthehat merged commit 3b7e915 into main Mar 29, 2024
5 checks passed
@patinthehat patinthehat deleted the add-ray-sync branch March 29, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant