Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeedsPermission annotated method with parameter doesn't work in Kotlin #376

Closed
hotchemi opened this issue Sep 17, 2017 · 2 comments
Closed

NeedsPermission annotated method with parameter doesn't work in Kotlin #376

hotchemi opened this issue Sep 17, 2017 · 2 comments
Assignees
@shiraji
Labels
bug
Milestone
3.0.1

Comments

@hotchemi
Copy link
Member

Log: https://gist.github.com/ryugoo/cf8d4057973eac940c7713e054c02c35
@hotchemi hotchemi added the bug label Sep 17, 2017
@shiraji
Copy link
Member

shiraji commented Sep 17, 2017

There are multiple issues here.

  • kotlin.String converts to java.lang.String
  • GrantableRequest declares as val
  • GrantableRequest should be nullable and initializes as null
  • XxxPermissionRequest has property that is the same name with primary constructor's one.

I am working on GrantableRequest and XxxPermissionRequest problems.

@hotchemi
Copy link
Member Author

Thx! I've just worked on it and here's a patch file.

patch.txt

hotchemi pushed a commit that referenced this issue Sep 17, 2017
Address GrantableRequest and XxxPermissionRequest problem which is de…
0ce9321 
…scribed in #376.
@hotchemi hotchemi added this to the 3.0.1 milestone Sep 17, 2017
@shiraji shiraji mentioned this issue Sep 17, 2017
Merged
@hotchemi hotchemi mentioned this issue Sep 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiraji shiraji

Labels
bug
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@hotchemi @shiraji