Fix compile error when request SYSTEM_ALERT_WINDOW on SupportFragment

[tomoya0x00]

This problem seems to have happened because android.support.v4.app.Fragment.getActivity() is specified as nullable.

And I also fix #429.

[shiraji]

Current generated code where we got syntax error for activity.getPackageName() and activity.startActivityForResult(intent, REQUEST_FOO)

fun ContactsFragment.fooWithPermissionCheck() {
  if (PermissionUtils.hasSelfPermissions(activity, *PERMISSION_FOO) || Settings.canDrawOverlays(activity)) {
    foo()
  } else {
    val intent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + activity.getPackageName()))
    activity.startActivityForResult(intent, REQUEST_FOO)
  }
}

fun ContactsFragment.onActivityResult(requestCode: Int) {
  when (requestCode) {
    REQUEST_FOO -> {
      if (PermissionUtils.hasSelfPermissions(activity, *PERMISSION_FOO) || Settings.canDrawOverlays(activity)) {
        foo()
      }
    }
  }
}

Generated Code

fun ContactsFragment.fooWithPermissionCheck() {
  if (PermissionUtils.hasSelfPermissions(this.activity, *PERMISSION_FOO) || Settings.canDrawOverlays(this.activity)) {
    foo()
  } else {
    val intent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + this.activity!!.getPackageName()))
    this.startActivityForResult(intent, REQUEST_FOO)
  }
}

fun ContactsFragment.onActivityResult(requestCode: Int) {
  when (requestCode) {
    REQUEST_FOO -> {
      if (PermissionUtils.hasSelfPermissions(this.activity, *PERMISSION_FOO) || Settings.canDrawOverlays(this.activity)) {
        foo()
      }
    }
  }
}

[shiraji]

I wonder can we ignore targetParam here?

override fun getActivityName(targetParam: String): String = "activity"

[shiraji]

The answer is No! We have PermissionRequest class

val intent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + target.activity!!.getPackageName()))

[shiraji]

We really need compiling test for kotlin now...

[shiraji]

We may need to discuss about !! but at this moment, we can merge this in.

[hotchemi]

Thank you so much! is it possible to avoid using !!? 👁

[shiraji]

We have 2 options to not to use !!

1. We can replace !! with ?. Like parse("package: " + activity?.getPackageName()) it ends up parse("package: null").

2. However, if we could add null check to Java version, we can do early return in kotlin so that we don't need to worry about this problem. (This generated code still have problem with startActivityForResult)

fun ContactsFragment.fooWithPermissionCheck() {
  val activity = activity ?: return // add this 
  if (PermissionUtils.hasSelfPermissions(activity, *PERMISSION_FOO) || Settings.canDrawOverlays(activity)) {
    foo()
  } else {
    val intent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + activity.getPackageName()))
    activity.startActivityForResult(intent, REQUEST_FOO)
  }
}

What do you think ? @hotchemi @tomoya0x00

[shiraji]

I'm not sure we should do this in this PR. We can ship this PR and then later version we can add null check in both Java and Kotlin.

[tomoya0x00]

I missed this comment.

I think we can add a null check later.

I think that early return is better. So We already use it in PermissionRequest class, I feel a sense of unity.

[hotchemi]

Yea I definitely prefer the latter one. But it can be another PR for sure~

[tomoya0x00]

@shiraji

We really need compiling test for kotlin now...

I think so too...

Does compiling test for Java exist?
I would like to refer if it exists.

@hotchemi

is it possible to avoid using !!?

I'll try it.
If activity is null, what do you think of the idea of ​​throw IllegalStateException ?

[shiraji]

@tomoya0x00

Does compiling test for Java exist?

compile-testing

There is no kotlin compiler testing that tests kapt generated test. @mannodermaus asks moshi team to open kotlin code gen test class

https://github.com/square/moshi/blob/3ecdfb6374758678859d1a75cb1b890ac28656fa/kotlin/codegen/src/test/java/com/squareup/moshi/kotlin/codegen/JsonClassCodegenProcessorTest.kt

[hotchemi]

OK let me merge! Hopefully someone would address early return..? cc: @tomoya0x00 😁