Skip to content

Remove native Fragment support #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2018
Merged

Remove native Fragment support #498

merged 2 commits into from
Jul 10, 2018

Conversation

hotchemi
Copy link
Member

@hotchemi hotchemi commented Jul 9, 2018

Finally!?

@hotchemi hotchemi changed the title Remove native support Remove native Fragment support Jul 9, 2018
Remove native Fragment support.
91162aa 
In favor of Android P.
@hotchemi hotchemi force-pushed the remove_native_support branch from a9c8f8d to 91162aa Compare July 9, 2018 17:25
@hotchemi hotchemi requested review from mannodermaus and shiraji July 9, 2018 17:26
mannodermaus
mannodermaus approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@mannodermaus mannodermaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How liberating! LGTM, just two notes on Javadoc maintenance

...ssor/src/main/kotlin/permissions/dispatcher/processor/impl/java/JavaFragmentProcessorUnit.kt Outdated
@@ -8,7 +8,7 @@ import javax.lang.model.type.TypeMirror
/**
* ProcessorUnit implementation for Fragments defined in the support-v4 library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated comment

.../src/main/kotlin/permissions/dispatcher/processor/impl/kotlin/KotlinFragmentProcessorUnit.kt Outdated
@@ -8,7 +8,7 @@ import javax.lang.model.type.TypeMirror
/**
* [permissions.dispatcher.processor.KtProcessorUnit] implementation for Fragments defined in the support-v4 library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated comment

@hotchemi
Copy link
Member Author

thx for the review!

@hotchemi hotchemi merged commit 06fea5d into master Jul 10, 2018
@hotchemi hotchemi deleted the remove_native_support branch July 10, 2018 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mannodermaus mannodermaus mannodermaus approved these changes

@shiraji shiraji Awaiting requested review from shiraji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotchemi @mannodermaus