Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CallNeedsPermissionDetector to scan only annotated classes #536

Merged
merged 3 commits into from
Oct 28, 2018
Merged

Fix CallNeedsPermissionDetector to scan only annotated classes #536

merged 3 commits into from
Oct 28, 2018

Conversation

hotchemi
Copy link
Member

@hotchemi hotchemi commented Oct 28, 2018 •
edited
Loading

Issue

Fixes #502

Overview

Fix CallNeedsPermissionDetector to scan only annotated classes.

@hotchemi hotchemi requested a review from shiraji October 28, 2018 07:31
shiraji
shiraji approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@shiraji shiraji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiraji
Copy link
Member

shiraji commented Oct 28, 2018

It seems to me too restricted to requires signed commits

@hotchemi
Copy link
Member Author

Thx! turned it off.

@hotchemi hotchemi merged commit 0c1a6b4 into master Oct 28, 2018
@hotchemi hotchemi deleted the issues/502 branch October 28, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiraji shiraji shiraji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotchemi @shiraji