Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed usb control message for various colours #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmpak
Copy link

@jmpak jmpak commented Apr 17, 2016

The colour values aren't working with the new lights and also the sequence of control message has changed

@perryn
Copy link
Owner

perryn commented Jun 30, 2016

hi @jmpak

which new lights are these?

@jmpak
Copy link
Author

jmpak commented Jul 5, 2016

The existing code did not work with the latest batch of Delcom 904006 lights that we ordered.
https://www.delcomproducts.com/productdetails.asp?productnum=904006

I had to tweak it to make it work

@rastadrian
Copy link

@perryn I can confirm this PR fixes the control sequence and the light values for the new Delcom lights. Thanks @jmpak !

@rastadrian
Copy link

Although now that I think about it, maybe this should be yet another device recipe rather than replacing the Delcom Gen2, this might break it for people where this original values were actually working...

@perryn
Copy link
Owner

perryn commented Oct 6, 2016

Hi @rastadrian and @jmpak

yes exactly, this should be really be a new device recipe. If either of you have the time to put that in a pull request, I'll do a new release

@rastadrian
Copy link

rastadrian commented Oct 7, 2016

@perryn @jmpak I did found an interesting issue though, the light specifications that @jmpak provided are actually for a USB device (Delcom 904006, 904007, 904008) using the exact same vendorId and productId that the light that you have in your project (awesome standards from Delcom) so now we face an interesting situation:

We have two usb devices with the same vendorId, the same productId and with different control transfer sequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants