More robust quoted names handling #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The '%s.%s' % (quote_id(foo), quote_id(bar)) is used inconsistently.
dvarrazzo
force-pushed
the
more-robust-quoted-names-handling
branch
from
37752c7 to
e712ba6
Compare
|
Ugh, I see a lots of things are failing in the test: this MR requires more work. It was necessary though to handle the case of a db with |
|
@dvarrazzo Daniele, do you have a minimal test case? I presume it would first suffice to do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a proper parser for a sequence of dot-separated quoted names.
Let quote_id do the merging back into dot-separated quoted names string, minimising the use of ad-hoc
%s.%swhere sometimes one side got unquoted.