Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Increase provisioning timer #80

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

ibakshay
Copy link
Contributor

As suggested in #79 (comment)

…terval to 10 minutes

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ibakshay
Copy link
Contributor Author

The workflow to update the documentation is getting skipped? 🤔 @nicolastakashi

@nicolastakashi
Copy link
Contributor

The workflow to update the documentation is getting skipped? 🤔 @nicolastakashi

@ibakshay

if: contains(github.event.pull_request.labels.*.name, 'dependencies')
this is why 😅 , maybe we should remove it and let it run on any version update.

@ibakshay
Copy link
Contributor Author

The workflow to update the documentation is getting skipped? 🤔 @nicolastakashi

@ibakshay

if: contains(github.event.pull_request.labels.*.name, 'dependencies')

this is why 😅 , maybe we should remove it and let it run on any version update.

I see. I did not notice that :D I am fine with letting it run on my version update if it is fine with you.
BTW also, this workflow has failed on checkout. - https://github.com/perses/helm-charts/actions/runs/13542298089/job/37845914791?pr=80

@nicolastakashi
Copy link
Contributor

@ibakshay interesting, this looks like it's not working on forks 🤔
Let's take it offline, maybe you can just run the make command on your own and we address it in another moment.

Wdyt?

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Copy link
Contributor Author

@ibakshay ibakshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibakshay interesting, this looks like it's not working on forks 🤔
Let's take it offline, maybe you can just run the make command on your own and we address it in another moment.

Wdyt?

Sure, roger that :)
updated the readme in ef58fa3 by running the make command :) This PR is good to go now :)

@nicolastakashi nicolastakashi merged commit 9c07f76 into perses:main Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants