fix: prevent to rerender when year or month has changed if daysInMont…

…h was equals to its prev value
persian-tools · Jun 11, 2021 · 3ca1c99 · 3ca1c99
1 parent 23ec235
commit 3ca1c99
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/src/hooks/usePicker.ts b/src/hooks/usePicker.ts
@@ -283,19 +283,24 @@ export function usePicker(props: WheelPickerProps) {
   // Calculate days in selected months
   useEffect(() => {
     if (!isObjectEmpty(selectedDate)) {
+      const $daysInMonth = calculateDaysInMonth(
+        Number(selectedDate.year),
+        Number(selectedDate.month),
+      );
       if (
-        previousSelectedDate?.month !== selectedDate?.month ||
-        previousSelectedDate?.year !== selectedDate?.year
+        (previousSelectedDate?.month !== selectedDate?.month ||
+          previousSelectedDate?.year !== selectedDate?.year) &&
+        daysInMonth !== $daysInMonth
       ) {
-        setDaysInMonth(
-          calculateDaysInMonth(
-            Number(selectedDate.year),
-            Number(selectedDate.month),
-          ),
-        );
+        setDaysInMonth($daysInMonth);
       }
     }
-  }, [selectedDate, previousSelectedDate?.year, previousSelectedDate?.month]);
+  }, [
+    selectedDate.month,
+    selectedDate.year,
+    previousSelectedDate?.year,
+    previousSelectedDate?.month,
+  ]);
 
   // Handlers
   /**