Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: body text URL hyperlinks #247

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix: body text URL hyperlinks #247

merged 2 commits into from
Aug 14, 2023

Conversation

grace-fagan
Copy link
Collaborator

@grace-fagan grace-fagan commented Aug 1, 2023

Closes #246
When we parse the body text to style proposal hyperlinks (see #195), we ignore URL hyperlinks, rendering all non-prop-link text in a <span> element. This PR adds a urlRegex to the body text parsing function and converts all URL hyperlinks to a styled <a> element.

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 1:07pm

@grace-fagan grace-fagan changed the title Fix: Body <a> Styling Fix: body text URL hyperlinks Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<a> element styling bugs
2 participants