-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StateSaver class. #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Nice work @gilwoolee.
I filed #185 as a follow-up issue to revisit the implementation once we understand what other properties need to be preserved.
We also need to decide how to handle topological changes in a MetaSkeleton
(e.g. change in the number of DegreeOfFreedom
s) that make this class semantically meaningless. That is a broader issue in DART, so let's ignore it for now.
|
||
MetaSkeletonStateSpaceSaver::~MetaSkeletonStateSpaceSaver() | ||
{ | ||
mSpace->getMetaSkeleton()->setPositions(mPositions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would be nice if we have a simple validity check whether the size of mPositions
is still equal to the dofs of the MetaSkeleton
(if not, we print a warning). I understand it wouldn't be able to catch other structural changes such as changing the joint type with the same dofs, but at least we could catch dimension changing cases.
…lrobotics/aikido into enhancement/brianhou/state-saver
…lrobotics/aikido into enhancement/brianhou/state-saver
Changes Unknown when pulling 412feea on enhancement/brianhou/state-saver into ** on master**. |
Changes Unknown when pulling 412feea on enhancement/brianhou/state-saver into ** on master**. |
RAII class suggested by @mkoval in personalrobotics/libherb#26.