Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using helper function for waiting for action server #192

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Using helper function for waiting for action server #192

merged 1 commit into from
Apr 26, 2017

Conversation

Shushman
Copy link
Contributor

This replaces the specific waitForServer() function in control/ros/RosTrajectoryExecutor with a call to the util function waitForActionServer introduced in #173

It also addresses the bug that the earlier waitForServer() function had, which was that it initialized currentTime with an extra timeoutDuration

@Shushman Shushman requested a review from mkoval April 25, 2017 15:10
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.12% when pulling bd57f12 on bugfix/rosTrajExecWaitForServer into dffdf28 on master.

mkoval
mkoval approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@mkoval mkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! 👍 for eliminating duplicate code. 🎉

@mkoval mkoval merged commit 797797f into master Apr 26, 2017
@mkoval mkoval deleted the bugfix/rosTrajExecWaitForServer branch April 26, 2017 04:08
@jslee02 jslee02 added this to the Aikido 0.1.0 milestone May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoval mkoval mkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shushman @coveralls @mkoval @jslee02