Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new ErrorStr API in tinyxml2 6.0.0 #290

Merged
merged 5 commits into from
Jan 6, 2018
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 6, 2018

There were API breaking changes in tinyxml2 6.0.0. This PR adds band-aid to support tinyxml2 6.0.0 and less.

Referenced https://bitbucket.org/ignitionrobotics/ign-common/pull-requests/87/support-new-errorstr-api-in-tinyxml2-600/diff


Before creating a pull request

  • Document new methods and classes (N/A)
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the Aikido 0.2.0 milestone Jan 6, 2018
@jslee02 jslee02 changed the title Support tinyxml2 6.0.0 and less Support new ErrorStr API in tinyxml2 6.0.0 Jan 6, 2018
@codecov
Copy link

codecov bot commented Jan 6, 2018

Codecov Report

Merging #290 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   80.25%   80.26%   +0.01%     
==========================================
  Files         195      195              
  Lines        5671     5671              
==========================================
+ Hits         4551     4552       +1     
+ Misses       1120     1119       -1
Impacted Files Coverage Δ
src/io/CatkinResourceRetriever.cpp 74.79% <ø> (ø) ⬆️
src/planner/ompl/CRRT.cpp 76.16% <0%> (+0.58%) ⬆️

@jslee02 jslee02 merged commit b466493 into master Jan 6, 2018
@jslee02 jslee02 deleted the support_tinyxml2_6 branch January 6, 2018 15:57
jslee02 added a commit that referenced this pull request Jan 8, 2018
jslee02 added a commit that referenced this pull request Jan 8, 2018
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant