Add methods for checking compatibility between DART objects and statespaces #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 81.1% 80.97% -0.14%
==========================================
Files 204 204
Lines 5913 5977 +64
==========================================
+ Hits 4796 4840 +44
- Misses 1117 1137 +20
|
jslee02
approved these changes
Jan 30, 2018
There was a problem hiding this comment.
Overall, looks good to me!
Suggestions:
-
It would be good if we actually use these functions here: https://github.com/personalrobotics/aikido/blob/master/src/rviz/TrajectoryMarker.cpp#L81.
-
Please update changelog for this PR
gilwoolee
pushed a commit
that referenced
this pull request
Jan 21, 2019
…spaces (#315) * Add JointStateSpace::checkJoint and MetaSkeletonStateSpace::checkMetaSkeleton. * Rename check* methods to isCompatible. * Rename methods. * Add tests. * Update CHANGELOG.md. * Use statespace checks in TrajectoryMarker. * Fix compilation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #292.
Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md