Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MetaSkeleton-dependent problems to aikido::planner::dart. #432

Merged
merged 3 commits into from
May 24, 2018

Conversation

brianhou
Copy link
Contributor

@brianhou brianhou commented May 22, 2018

Some problem types are associated with a MetaSkeleton (ConfigurationToTSR, ConfigurationToEndEffector[Offset|Pose]). However, the MetaSkeleton that we use to solve those problems can't be stored in the problem itself because we currently take Problems as const.

@jslee02 and I decided that it would make sense for Planners that solve these problems to take in a non-const MetaSkeleton in the constructor. This PR introduces the aikido::planner::dart namespace for these problem types.

In a future PR, we should add corresponding SingleProblemPlanners for these problems. It would also be useful to have an aikido::planner::dart::ConfigurationToConfigurationPlanner that takes in a non-const MetaSkeleton in its constructor so that we can adapt them more easily.


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@brianhou brianhou added this to the Aikido 0.3.0 milestone May 22, 2018
@brianhou brianhou requested review from jslee02 and sniyaz May 22, 2018 00:25
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #432 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   80.02%   80.03%   +0.01%     
==========================================
  Files         235      235              
  Lines        6002     6002              
==========================================
+ Hits         4803     4804       +1     
+ Misses       1199     1198       -1
Impacted Files Coverage Δ
...do/planner/dart/ConfigurationToEndEffectorPose.hpp 0% <ø> (ø)
...orFieldConfigurationToEndEffectorOffsetPlanner.cpp 68.42% <ø> (ø) ⬆️
...r/vectorfield/MoveEndEffectorOffsetVectorField.cpp 74.28% <ø> (ø) ⬆️
...r/dart/ConfigurationToEndEffectorOffsetPlanner.hpp 100% <ø> (ø)
.../planner/dart/ConfigurationToEndEffectorOffset.cpp 73.68% <ø> (ø)
...do/planner/vectorfield/BodyNodePoseVectorField.hpp 100% <ø> (ø) ⬆️
.../planner/dart/ConfigurationToEndEffectorOffset.hpp 100% <ø> (ø)
...r/dart/ConfigurationToEndEffectorOffsetPlanner.cpp 100% <ø> (ø)
...rc/planner/dart/ConfigurationToEndEffectorPose.cpp 0% <ø> (ø)
include/aikido/planner/dart/ConfigurationToTSR.hpp 0% <ø> (ø)
... and 5 more

@brianhou brianhou force-pushed the enhancement/brianhou/dart-planners branch from 1cc55b4 to bc7653e Compare May 23, 2018 00:19
@brianhou brianhou requested review from jslee02 and sniyaz and removed request for jslee02 and sniyaz May 23, 2018 00:20
@@ -50,7 +50,7 @@ MoveEndEffectorOffsetVectorField::MoveEndEffectorOffsetVectorField(
bool MoveEndEffectorOffsetVectorField::evaluateCartesianVelocity(
const Eigen::Isometry3d& pose, Eigen::Vector6d& cartesianVelocity) const
{
using dart::math::logMap;
using ::dart::math::logMap;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a review thing but more a question from somebody who doesn't know C++ as well- what is the purpose of adding :: here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading :: is used to represent the following namespace is a top-level namespace. We use this when there is the same name namespace in the "active" namespace. In our case, we use it to distinguish ::dart (i.e., the DART's top-level namespace) and ::aikido::statespace::dart/::aikido::planner::dart.

@sniyaz
Copy link

sniyaz commented May 23, 2018

This personally looks good to me 👍

@@ -0,0 +1,44 @@
set(sources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we only make a new sub-component when it requires optional 3rd-party dependencies. For example, other dart subdirectories of statespace and constraint are not components but included its parent components.

In this sense, I think aikido_planner_ompl and aikido_planner_vectorfield also shouldn't be sub-components.

@brianhou brianhou merged commit a89dd3c into master May 24, 2018
@brianhou brianhou deleted the enhancement/brianhou/dart-planners branch May 24, 2018 00:16
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
* Move MetaSkeleton-dependent problems and planners.

* Remove planner_dart component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants