-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MetaSkeleton-dependent problems to aikido::planner::dart. #432
Conversation
1cc55b4
to
bc7653e
Compare
@@ -50,7 +50,7 @@ MoveEndEffectorOffsetVectorField::MoveEndEffectorOffsetVectorField( | |||
bool MoveEndEffectorOffsetVectorField::evaluateCartesianVelocity( | |||
const Eigen::Isometry3d& pose, Eigen::Vector6d& cartesianVelocity) const | |||
{ | |||
using dart::math::logMap; | |||
using ::dart::math::logMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a review thing but more a question from somebody who doesn't know C++ as well- what is the purpose of adding ::
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The leading ::
is used to represent the following namespace is a top-level namespace. We use this when there is the same name namespace in the "active" namespace. In our case, we use it to distinguish ::dart
(i.e., the DART's top-level namespace) and ::aikido::statespace::dart
/::aikido::planner::dart
.
This personally looks good to me 👍 |
src/planner/dart/CMakeLists.txt
Outdated
@@ -0,0 +1,44 @@ | |||
set(sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we only make a new sub-component when it requires optional 3rd-party dependencies. For example, other dart subdirectories of statespace
and constraint
are not components but included its parent components.
In this sense, I think aikido_planner_ompl
and aikido_planner_vectorfield
also shouldn't be sub-components.
* Move MetaSkeleton-dependent problems and planners. * Remove planner_dart component.
Some problem types are associated with a
MetaSkeleton
(ConfigurationToTSR
,ConfigurationToEndEffector[Offset|Pose]
). However, theMetaSkeleton
that we use to solve those problems can't be stored in the problem itself because we currently takeProblem
s asconst
.@jslee02 and I decided that it would make sense for
Planner
s that solve these problems to take in a non-constMetaSkeleton
in the constructor. This PR introduces theaikido::planner::dart
namespace for these problem types.In a future PR, we should add corresponding
SingleProblemPlanner
s for these problems. It would also be useful to have anaikido::planner::dart::ConfigurationToConfigurationPlanner
that takes in a non-constMetaSkeleton
in its constructor so that we can adapt them more easily.Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md