Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set start state to state space before creating vector field #456

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

dqyi11
Copy link
Contributor

@dqyi11 dqyi11 commented Aug 10, 2018

This is only one line change so I did not create an issue.

In creating MoveEndEffectorOffsetVectorField, mStartPose is initialized from the current end-effector pose. https://github.com/personalrobotics/aikido/blob/master/src/planner/vectorfield/MoveEndEffectorOffsetVectorField.cpp#L32
We shall update the position of metaSkeleton before creating the vector field so that the start pose of the planning matches mStartPose. If not, it might start with a big deviation when the given startState is very different with current state of meta skeleton.

This is a fix to #426


Before creating a pull request

  • Document new methods and classes (N/A)
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md (N/A)
  • Add unit test(s) for this change (N/A)

@dqyi11 dqyi11 added the bug label Aug 10, 2018
@dqyi11 dqyi11 added this to the Aikido 0.3.0 milestone Aug 10, 2018
@dqyi11 dqyi11 requested a review from sniyaz August 10, 2018 20:35
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if we have a simple regression test for this.

@dqyi11
Copy link
Contributor Author

dqyi11 commented Aug 10, 2018

Yes, maybe adding a test case when the start state is very different from the current state of meta skeleton.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files         258      258           
  Lines        6303     6303           
=======================================
  Hits         4973     4973           
  Misses       1330     1330
Impacted Files Coverage Δ
src/planner/vectorfield/VectorFieldPlanner.cpp 78.18% <100%> (ø) ⬆️

@brianhou brianhou merged commit 327b77c into master Aug 18, 2018
@brianhou brianhou deleted the bugfix/setStartStateInVectorFieldPlanner branch August 18, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants