-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gtest version to 1.8.1 #478
Conversation
Were there any changes to code that we've written, or is the only change to update |
I believe there is one thing we changed to suppress build warnings by adding Alternatively, git submodule can be used with custom build script instead of using the provided one by gtest, if git submodule is preferred. |
Hmm, this actually makes me mildly concerned. What if we update gtest again in the future, and don't remember that that change (or other future changes we make) were necessary? New proposal: what if we fork |
Agreed. The proposal sounds reasonable to me. As a note, Anyways, I don't have any strong preference for this. Any method that is convenient to maintain would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge for now so we can unbreak Travis. @jslee02 can you make an issue to figure out how to deal with this? Thanks!
This also fixes the build failure on Ubuntu Bionic.
Before merging a pull request
CHANGELOG.md