Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weights to Rankers #484

Merged
merged 9 commits into from
Jan 24, 2019
Merged

Add weights to Rankers #484

merged 9 commits into from
Jan 24, 2019

Conversation

gilwoolee
Copy link
Contributor

@gilwoolee gilwoolee commented Jan 16, 2019 •
edited
Loading

This PR adds weights as an optional argument to rankers. The weights are used to weight the joints in ordering the configurations.

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@gilwoolee gilwoolee requested a review from aditya-vk January 16, 2019 04:20
aditya-vk
aditya-vk previously approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@aditya-vk aditya-vk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it should be good to merge once Travis succeeds

@gilwoolee gilwoolee added this to the Aikido 0.3.0 milestone Jan 24, 2019
@gilwoolee gilwoolee merged commit 773633b into master Jan 24, 2019
@gilwoolee gilwoolee deleted the weights-for-ranking-planner branch January 24, 2019 18:22
@gilwoolee gilwoolee mentioned this pull request Feb 17, 2019
Closed
5 tasks
@aditya-vk aditya-vk mentioned this pull request Feb 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-vk aditya-vk aditya-vk left review comments

Assignees

@aditya-vk aditya-vk

Labels
None yet
Projects
None yet
Milestone
Aikido 0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gilwoolee @aditya-vk