-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PoseEstimatorModule, AssetDatabase #508
Conversation
…TE marker to be handled earlier, remove objectName from AssetDatabase since this information is already given by the marker (further, it removes the need for pr_assets to have different name for objects of same shape, e.g. cans or food items).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One substantial change, a couple of comment nits.
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 262 262
Lines 6792 6792
=======================================
Hits 5277 5277
Misses 1515 1515 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nit comments, but generally looks good to me.
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit about DetectedObject-impl.hpp
.
This PR contains the following updates:
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md