-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect spline-conversions #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atenate(Spline, Spline), convertToKunzPath(Spline), toR1JointTrajector(Spline)
brianhou
previously approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
brianhou
previously approved these changes
Feb 22, 2019
brianhou
previously approved these changes
Feb 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 77.67% 77.75% +0.07%
==========================================
Files 262 262
Lines 6792 6713 -79
==========================================
- Hits 5276 5220 -56
+ Misses 1516 1493 -23
|
brianhou
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that we convert
Spline
toInterpolated
incorrectly or treatSpline
as if it's only a set of Waypoints. This PR removes all such use cases:Removes
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md