Support state snapshots with only named skeletons. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilwoolee
previously approved these changes
May 14, 2019
jslee02
suggested changes
Jul 21, 2019
brianhou
commented
Jul 21, 2019
brianhou
commented
Jul 21, 2019
Co-Authored-By: gilwoolee <gilwoo301@gmail.com>
jslee02
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking a snapshot of the world, we might only care about certain skeletons. For example, when constructing a dataset of possible robot environments, we wouldn't want to preserve the robot's state since that will change during planning.
Efficiency concerns: this implementation uses a lot of
getSkeleton(name)calls, each of which I think is linear in the number of Skeletons in the world.Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md