Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with CloseHand() for ADA in sim #254

Merged
merged 5 commits into from
Feb 3, 2016
Merged

Fixed issue with CloseHand() for ADA in sim #254

merged 5 commits into from
Feb 3, 2016

Conversation

Stefanos19
Copy link
Contributor

No description provided.

@mkoval
Copy link
Member

mkoval commented Jan 10, 2016

Note that MoveHand function ignores collisions and will always terminate with the hand fully closed, even if it is penetrating an object. The robot.task_manipulation.CloseFingers() function simulates closing the fingers until they are in collision. This is why we have separate functions for CloseFingers and OpenFingers.

@mkoval
Copy link
Member

mkoval commented Jan 22, 2016

@Stefanos19 Can you take a look at my comment above?

@mkoval mkoval added the bug label Jan 22, 2016
@Stefanos19
Copy link
Contributor Author

I think the issue is that the command: robot.task_manipulation.prob.SendCommand('CloseFingers') returns the following error:
[grasperplanner.cpp:258 PlanPath] no objects in environment

@mkoval
Copy link
Member

mkoval commented Feb 3, 2016

I will merge this for now. However, it is really not correct - we should figure out why CloseFingers is failing.

@Stefanos19 Please make an issue about this.

mkoval added a commit that referenced this pull request Feb 3, 2016
Workaround for CloseFingers on MicoHand.
@mkoval mkoval merged commit 12d352a into personalrobotics:master Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants