Patched TSR wrapping to use Bw_cont and added TSR unit test. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psigen
changed the title
| Bw_interval = numpy.minimum(Bw_interval, 2*pi) | ||
|
|
||
| Bw_cont[3:6, 0] = wrap_to_interval(Bw_cont[3:6, 0]) | ||
| Bw_cont[3:6, 1] = Bw_cont[3:6, 0] + Bw_interval |
There was a problem hiding this comment.
This can produce values in the range [ -pi, 3*pi ]. Is that intentional?
|
This pull request most likely does not fix the I'll create another issue to track the |
|
👍 I think we need to carefully figure out a way to keep |
|
I logged the |
mkoval
added a commit
that referenced
this pull request
Oct 9, 2015
Patched TSR wrapping to use Bw_cont and added TSR unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #190 by changing the wrapping function to be bounds-aware. This allows wrapping into the
Bwinterval for checks, and wrapping into the[-pi, pi)interval for samples, and also fixes various bugs with zero-measure intervals wrapping incorrectly.The PR also adds a unit test for TSRs, although it is very simple right now.