Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fuerte check for SetChuckingDirection #3

Merged
merged 1 commit into from
Aug 4, 2014

Conversation

es92
Copy link
Contributor

@es92 es92 commented Aug 2, 2014

SetChuckingDirection is failing on my machine. Not sure whether that's because of fuerte (I don't see how that could be), the way fuerte is loading herb, or something else.

Here's the error I get:

openravepy.openravepy.openravepy_ext.openrave_exception: openrave (Assert): virtual void OpenRAVE::RobotBase::Manipulator::SetChuckingDirection(const std::vector&):64chuckingdirection.size() == GetGripperDOF(), (eval 4 == 3)

Any thoughts on whether this is how fuerte loads herb or something else? If its something else I'll change this PR to just removing the check.

@es92
Copy link
Contributor Author

es92 commented Aug 2, 2014

actually I was a few commits behind, recompiling and trying now

@es92
Copy link
Contributor Author

es92 commented Aug 2, 2014

Nah still happens

@es92
Copy link
Contributor Author

es92 commented Aug 2, 2014

Oh wait I just realized I how the ros wrapper works, I can't believe the first thing it does is reset --hard, maybe it'll work now.

EDIT: nope, still doesn't work, same error

@mkoval
Copy link
Member

mkoval commented Aug 3, 2014

You should check the number of gripper joints in the HERB model, e.g. robot.right_arm.GetGripperIndices(). There should be four: three for the fingers and one for the spread. It sounds like one of the joints (perhaps the spread?) is missing in your model.

@es92
Copy link
Contributor Author

es92 commented Aug 4, 2014

Yep, there's only 3 in my model - just [7,8,9]. The left arm also has only 3, [18,19,20].

@mkoval
Copy link
Member

mkoval commented Aug 4, 2014

In that case, I suggest setting the chucking direction iff len(GetGripperIndices()) == 4. The chucking direction is already correct in Fuerte. so there's nothing to do for the case len(GetGripperIndices()) == 3.

@es92
Copy link
Contributor Author

es92 commented Aug 4, 2014

make s sense, added the check

mkoval added a commit that referenced this pull request Aug 4, 2014
…ForSetChuckingDirection

Only call SetChuckingDirection on the new HERB model.
@mkoval mkoval merged commit 15c79ee into master Aug 4, 2014
@es92 es92 deleted the patch/switchToCatkinCheckForSetChuckingDirection branch August 4, 2014 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants