* chore(helper): Rename GetShamirSharedRandomElement to ShamirSharedS…

…ecretKey, change it accordingly everywhere it is used. * chore(fhks_bbs_plus): Remove Println statements
perun-network · Jan 2, 2025 · 0ccc67c · 0ccc67c
1 parent f49b3e1
commit 0ccc67c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/fhks_bbs_plus/encode_test.go b/fhks_bbs_plus/encode_test.go
@@ -69,13 +69,9 @@ func TestPerPartyPreSignatureSerializationDeserialization(t *testing.T) {
 	dataSerialized, err := preSigOriginal.ToBytes()
 	assert.NoError(t, err)
 
-	preSigDeserialized, asshare, err := fhks_bbs_plus.FromBytes(dataSerialized)
+	preSigDeserialized, _, err := fhks_bbs_plus.FromBytes(dataSerialized)
 	assert.NoError(t, err)
 
-	fmt.Println("preSigOriginal.AShare: ", preSigOriginal.AShare)
-	fmt.Println("preSigDeserialized.AShare: ", preSigDeserialized.AShare)
-	fmt.Println("preSigDeserialized asshare: ", asshare)
-
 	assert.True(t,
 		preSigOriginal.AShare.Equal(preSigDeserialized.AShare), "AShare mismatch")
 	assert.True(t,

diff --git a/helper/secret_sharing.go b/helper/secret_sharing.go
@@ -95,8 +95,8 @@ func GetShamirSharedRandomElement(rng io.Reader, t, n int) (*bls12381.Fr, []*bls
 	return secretKeyElement, shares
 }
 
-// GetShamirSharedRandomElement generates a t-out-of-n shamir secret sharing of a random element, using a provided secret key
-func GetShamirSharedRandomElementFromSecretKey(skey *bls12381.Fr, t, n int) []*bls12381.Fr {
+// ShamirSharedSecretKey generates a t-out-of-n shamir secret sharing of the provided secret key
+func ShamirSharedSecretKey(skey *bls12381.Fr, t, n int) []*bls12381.Fr {
 
 	coefficients := make([]*bls12381.Fr, t-1)
 	for i := 0; i < t-1; i++ {

diff --git a/precomputation/precomputation_mock.go b/precomputation/precomputation_mock.go
@@ -111,7 +111,7 @@ func GeneratePPPrecomputationNOutOfN(seedArray [16]uint8, tau, K, N int) (*bls12
 }
 
 func GeneratePCFPCGOutputMockedFromSecretKey(sk *bls12381.Fr, t int, k int, n int) PCFPCGOutput {
-	skShares := helper.GetShamirSharedRandomElementFromSecretKey(sk, t, n)
+	skShares := helper.ShamirSharedSecretKey(sk, t, n)
 
 	aShares := helper.GetRandomElements(k, n)
 	eShares := helper.GetRandomElements(k, n)