Add minimum and maximum repetition rules #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads the way into having max repetetions and min repetitions.
dragostis
approved these changes
Nov 19, 2017
dragostis
requested changes
Nov 20, 2017
There was a problem hiding this comment.
One more thing apart from renaming the function: RepMin should also be added to the list of unbounded repetitions.
|
I'll be jumping on this in the next couple of days. Haven't looked too close to the validator code yet, but it definitely needs to address RepMin at a minimum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the .pest grammar files allowed the following repetition patterns:
a*- 0 or morea+- 1 or morea{n}- exactly na{m,n}- from m to nThis PR adds two more forms:
a{,n}- up to na{n,}- at least nThis is largely syntactic sugar. Minimum matching can also be achieved using the pattern
a{n} ~ a*, and maximum can be achieved usinga{0,n}ora?{n}.What the new forms bring to the table is a consistent, unified syntax for dealing with counted repetitions greater than 1.